Fix documentation security issue #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaydipGabani
requested changes
Jun 24, 2025
|
@TIJMacLean did you miss running |
|
@JaydipGabani I hadn't - I've tried to do that all now but as a non-developer, I've been struggling to get all the dependencies and versions working correctly. I've tried again with the make commands and having moved the changes into the src directory instead, but I could get the unit tests to run correctly on my system. So hopefully they pass here! |
|
@JaydipGabani Afternoon - is there any update on whether this is more in line with what you were expecting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a security issue where the "latest" tag could be deployed even when it was disallowed, by using the format image:port/repo for a container image rather than the expected image/repo:tag. image:port/repo passed the contains ":" check, and defaults to pulling the latest
Which issue(s) does this PR fix (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes a report through the security email
Special notes for your reviewer: