Skip to content

fix: drop capability shoud be tested without case sensitivity #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PierrePIRONIN
Copy link

What this PR does / why we need it:
Fixes a case sensitive test concerning the drop of ALL/all capability.

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #668

Special notes for your reviewer:

@PierrePIRONIN PierrePIRONIN requested a review from a team as a code owner July 15, 2025 09:07
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! can you also add example to test this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with any changes in logic of the policy, version should be updated. So in this case the version should be updated to 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missingDropCapabilitiesByContainer should work with both 'all' and 'ALL'
2 participants