Benchmark fixes #7765
Merged
Benchmark fixes #7765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of benchmarks did not have a `for range b.N` (or equivalent) loop in them, leading to nothing being measured. This PR fixes that, along with some cleanups in benchmarks found along the way. Also remove `b.StopTimer` where not absolutely necessary, as that is [notoriously buggy](golang/go#27217), and had some benchmarks hang for a very long time. Signed-off-by: Anders Eknert <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of benchmarks did not have a
for range b.N(or equivalent) loop in them, leading to nothing being measured. This PR fixes that, along with some cleanups in benchmarks found along the way.Also remove
b.StopTimercalls where not absolutely necessary, as that is notoriously buggy, and had some benchmarks hang for a very long time.