-
Notifications
You must be signed in to change notification settings - Fork 1.5k
website: Use latest release rather than edge #7781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Use latest release rather than edge #7781
Conversation
c42c4ad
to
1e76158
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
620b9b5
to
766c8a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
docs/Makefile
Outdated
git diff-index --quiet HEAD -- || (echo "Latest release build must be done without working changes" && exit 1) | ||
git fetch --tags origin | ||
$(eval CURRENT_BRANCH := $(shell git branch --show-current)) | ||
git checkout $$(git describe --tags --abbrev=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we assert the tag format here. I.e. that it fits the v<semver>
structure we use for release tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. I have created a new tag locally to check:
$ git tag --sort=-version:refname | head -n 3
v2.15.0-fffff
v1.6.0
v1.5.1
$ git tag --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -1
v1.6.0
53482ee
to
f39d2ac
Compare
💭 Does this mean we'll stop building the website on code pushes to main, but only build it on tag pushes, if the tag also is the latest one? |
f39d2ac
to
a952ed4
Compare
The site will still be built on pushed to main, but only the latest tag will be used. This is because it's 'easier' and more robust than sending events at the correct time to build the site. In theory. |
e349088
to
bc9c208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bc9c208
to
8f724be
Compare
Signed-off-by: Charlie Egan <[email protected]>
8f724be
to
2a3ba46
Compare
This is intended to make the default view of the OPA site and docs from the latest release, rather than from edge.
Deploy preview command will need to show edge, but using that to test the prod command atm.
When
make netlify-latest
was used on the preview, we see that the site was built from the latest release: