sdk: options store takes precedence over ext store #7800
Conversation
Rationale is that if the user has passed a store into the SDK, it probably has something in it already, like data and policies. Signed-off-by: Stephan Renatus <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks for putting this PR together! The changes here solve a potential "footgun" around using the SDK: if you registered a bundle store func elsewhere, you can wind up with 2x stores (one the user passed in, and one created by the store func for bundle storage)! 😨
That behavior is obviously surprising when you're using the SDK and populating the store yourself, so this change brings management of stores more into line with what users might expect: if they pass in a storage.Store instance, that's what gets used, and if they don't provide a choice, they get whatever default is available. (The bundle storage func gets invoked, or OPA makes them a new inmem store behind the scenes.)
Rationale is that if the user has passed a store into the SDK, it probably has something in it already, like data and policies.
Excellent rationale from @philipaconrad, copied here to make it stand out a bit more: