Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMe: high level model - review findings #748

Open
8 tasks
boekholt opened this issue Jun 12, 2018 · 0 comments
Open
8 tasks

NVMe: high level model - review findings #748

boekholt opened this issue Jun 12, 2018 · 0 comments
Assignees

Comments

@boekholt
Copy link
Contributor

boekholt commented Jun 12, 2018

Comments gathered during review of nvme_top_i.sv:

  • Handling of error conditions for NVMe read and write operations is missing.
  • Is it possible to remove the #1 operation at the end of tasks nvme_cmd_read and `nvme_cmd_write?
  • Should we remove the unused task ddr_axi_test?
  • Is task axi_ddr_reset required?
  • Set ACT_bresp and ACT_rresp to 2'hx together with releasing of ACT_bvalid and ACT_rvalid
  • Add support for NVMe host admin registers
  • Add NVMe lite model description (copy README.md from ibm github)
  • Action Register Write Statemachine: Probably need to delay issuing of nvme_operation() in state WRITE_BUFFER similar to the WRITE_BURST implementation
@fhaverkamp fhaverkamp self-assigned this Jul 11, 2018
@fhaverkamp fhaverkamp changed the title NVMe high level model - review findings NVMe: high level model - review findings Jul 11, 2018
@boekholt boekholt self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants