provide an alternate method to set liboqs installation path #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulti version testing
…ulti version testing Signed-off-by: Vysakh P Pillai <[email protected]>
|
Hi @vppillai, is there a reason you closed this PR? It seems to me like a useful feature to support. |
|
Hi Spencer,
I forgot to sign the commits and and pre merge tested were complaining.
Cancelled it thinking of taking the easy route of raising a new PR on a
clean fork, but got sidetracked with other stuff.
Let me raise a new PR with a clean fork later today. Sorry about the
confusion. I should have left a message in the PR before I closed it.
Cheers,
Vysakh
…On Wed, Oct 30, 2024, 7:36 a.m. Spencer Wilson ***@***.***> wrote:
Hi @vppillai <https://github.com/vppillai>, is there a reason you closed
this PR? It seems to me like a useful feature to support.
—
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3XJSTK3LME5T2LNDXMWKLZ6DVHTAVCNFSM6AAAAABQQE67BOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGM3DKMRUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
raised #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an alternate method (OQS_INSTALL_PATH) to specify the LIBOQS installation path.