-
Notifications
You must be signed in to change notification settings - Fork 580
Fix #2057 and some OpenSSL 3.x compatibility related issues #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erendemirel
wants to merge
20
commits into
open-quantum-safe:main
Choose a base branch
from
erendemirel:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+518
−454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- scope SHA/AES functions to their specific component flags
…QS_OSSL_FUNC macro definition
…s in UOV algorithms
…NSSL_ to _UTILS_OQS_
There is a formatting issue, I will have a look later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve the issue #2057 alongside with some related issues I came across.
Issues Fixed:
Issue opensslconf.h not used #2057 - Missing opensslconf.h Include
OpenSSL 3.x Naming Conflicts- OpenSSL 3.x defines OSSL_FUNC as a type, conflicting with liboqs's macro definition:
Renamed OSSL_FUNC to OQS_OSSL_FUNC across the codebase.
Updated all UOV config.h files to change fallback from #define UTILS_OPENSSL to #define UTILS_OQS, ensuring UOV algorithms use liboqs hash abstraction.
Fixed conditional compilation logic in all UOV utils_hash.c files to explicitly prevent OpensSL usage when UTILS_OQS is defined:
Note: Also wrapped any remaining direct OpenSSL calls with OQS_OSSL_FUNC() to ensure complete symbol isolation.
Updated function calls to resolves CI symbol visibility check failures:
Non-OpenSSL builds compile successfully.
Functional tests pass.
I expect no breaking changes to public API.
Note: This is my first contribution to the repo, so a thorough review might be needed.
No additional tests needed, this PR fixes existing functionality rather than adding new features.
No
No