fix: resolve a11y warnings for label-has-associated-control rule #4152

shubhamchasing · 2024-10-03T18:03:46Z

Description

Fixes warnings for rule - jsx-a11y/label-has-associated-control

Related Tickets & Documents

Fixes #4126

Mobile & Desktop Screenshots/Recordings

Before

After

Steps to QA

1 run npm run lint in the root folder and see warnings are not occurring.

Tier (staff will fill in)

Tier 1
Tier 2
Tier 3
Tier 4

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2024-10-03T18:03:50Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`c511e7f`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6723e299acdf0100085ae8cb
😎 Deploy Preview	https://deploy-preview-4152--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-10-03T18:04:05Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`c511e7f`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6723e29927008d00088b5c83
😎 Deploy Preview	https://deploy-preview-4152--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

components/AddContributorsHeader/add-contributors-header.tsx

components/atoms/Search/search.tsx

components/organisms/UserSettingsPage/user-settings-page.tsx

components/organisms/UserSettingsPage/developer-pack-form.tsx

components/organisms/UserSettingsPage/user-settings-page.tsx

components/shared/DayRangePicker.tsx

nickytonline · 2024-10-24T18:27:26Z

Hi @shubhamchasing, just seeing if you're blocked on anything. No rush on this, just checking in.

shubhamchasing · 2024-10-24T21:03:10Z

My apologies @nickytonline I will submit the changes before this weekend, thanks for offering help

nickytonline · 2024-10-24T21:33:46Z

My apologies @nickytonline I will submit the changes before this weekend, thanks for offering help

No need to apologize. 😎 I was just checking in.

shubhamchasing · 2024-10-24T22:19:51Z

@nickytonline It seems I made some mistake I merged the latest changes to my fix branch and resolved the conflicts but components/organisms/UserSettingsPage/developer-pack-form.tsx empty file is still there, can I delete the empty file in this PR or what can be other solution?

nickytonline · 2024-10-25T12:39:57Z

components/organisms/UserSettingsPage/developer-pack-form.tsx no longer exists so if you merge latest into your branch, it should remove it. If you run into issues, delete the file in your PR.

shubhamchasing · 2024-10-26T22:45:20Z

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

Edit: I think the below files are unused too or I am making a mistake to find them, please confirm

components/molecules/FilterCardSelect/filter-card-select.tsx used in components/molecules/FilterHeader/filter-header.tsx it is unused
components/molecules/SelectReportsFilter/select-reports-filter.tsx used in components/organisms/Reports/reports.tsx but it is unused and its related files
components/molecules/TeamMemberRow/team-member-row.tsx used in components/molecules/TeamMembersConfig/team-members-config.tsx it is unused

please let me know what files to remove so I do not remove any file which is used somewhere

nickytonline · 2024-10-26T23:57:39Z

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

@shubhamchasing, yes, the components/organisms/InsightPage/InsightPage.tsx can be removed as well.

shubhamchasing · 2024-10-27T00:16:23Z

please check the edited comment #4152 (comment)

shubhamchasing · 2024-10-28T22:51:41Z

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

Edit: I think the below files are unused too or I am making a mistake to find them, please confirm

components/molecules/FilterCardSelect/filter-card-select.tsx used in components/molecules/FilterHeader/filter-header.tsx it is unused

components/molecules/SelectReportsFilter/select-reports-filter.tsx used in components/organisms/Reports/reports.tsx but it is unused and its related files

components/molecules/TeamMemberRow/team-member-row.tsx used in components/molecules/TeamMembersConfig/team-members-config.tsx it is unused

please let me know what files to remove so I do not remove any file which is used somewhere

@nickytonline I understand you must be busy but I wanted to close this PR as I took more time on this PR than I should have

brandonroberts · 2024-10-30T19:05:30Z

Apologies @shubhamchasing. Did you mean close as in complete, or no longer work on?

shubhamchasing · 2024-10-31T14:48:07Z

I will complete, just waiting for Nick's input

…n-sauced#4126)

…hanges

nickytonline

Thanks for working on this @shubhamchasing. I made a couple tweaks and updated the branch. This is good to go. Thanks for your patience on this one!

shubhamchasing · 2024-11-04T09:26:03Z

Thanks @nickytonline, I learned something new 🚀

shubhamchasing · 2024-11-27T17:46:14Z

Hey guys, I was just checking if any help is needed on this to successfully merge the PR.

shubhamchasing requested review from brandonroberts, nickytonline and zeucapua as code owners October 3, 2024 18:03

nickytonline suggested changes Oct 6, 2024

View reviewed changes

components/AddContributorsHeader/add-contributors-header.tsx Outdated Show resolved Hide resolved

components/atoms/Search/search.tsx Outdated Show resolved Hide resolved

components/organisms/UserSettingsPage/user-settings-page.tsx Show resolved Hide resolved

nickytonline suggested changes Oct 8, 2024

View reviewed changes

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

shubhamchasing requested a review from jpmcb as a code owner October 13, 2024 01:40

nickytonline suggested changes Oct 15, 2024

View reviewed changes

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

nickytonline reviewed Oct 21, 2024

View reviewed changes

components/organisms/UserSettingsPage/developer-pack-form.tsx Outdated Show resolved Hide resolved

nickytonline suggested changes Oct 21, 2024

View reviewed changes

components/organisms/UserSettingsPage/user-settings-page.tsx Show resolved Hide resolved

components/shared/DayRangePicker.tsx Outdated Show resolved Hide resolved

brandonroberts closed this Oct 30, 2024

brandonroberts reopened this Oct 30, 2024

nickytonline added the hacktoberfest-accepted label Oct 31, 2024

shubhamchasing added 5 commits October 31, 2024 15:40

fix: resolve a11y warnings for label-has-associated-control rule (ope…

bcbf1bb

…n-sauced#4126)

chore: remove unused add-contributors-header.tsx file

3f479cf

fix: add sr-only label to Search component

f65b10c

fix: replace <label> with <h2>

d47a386

fix: add sr-only label to SingleSelect component and make necessary c…

f938dc3

…hanges

shubhamchasing added 2 commits October 31, 2024 15:41

fix: add missing labelText prop

d2c9fcb

chore: remove unused InsightPage.tsx file

2c86e3e

nickytonline force-pushed the fix-a11y-label-has-associated-control-warning branch from e48891e to 2c86e3e Compare October 31, 2024 19:43

nickytonline enabled auto-merge October 31, 2024 19:43

nickytonline added 3 commits October 31, 2024 15:48

fixed a merge conflict

642d5a8

fix: replaced orphan label with an h2

c4f0ae0

fix: sorted out single select label

c511e7f

nickytonline approved these changes Oct 31, 2024

View reviewed changes

zeucapua approved these changes Oct 31, 2024

View reviewed changes

brandonroberts approved these changes Oct 31, 2024

View reviewed changes

Uh oh!

Uh oh!

fix: resolve a11y warnings for label-has-associated-control rule #4152

Are you sure you want to change the base?

fix: resolve a11y warnings for label-has-associated-control rule #4152

Conversation

shubhamchasing commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

Uh oh!

netlify bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for oss-insights ready!

Uh oh!

netlify bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for design-insights ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickytonline commented Oct 24, 2024

Uh oh!

shubhamchasing commented Oct 24, 2024

Uh oh!

nickytonline commented Oct 24, 2024

Uh oh!

shubhamchasing commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickytonline commented Oct 25, 2024

Uh oh!

shubhamchasing commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickytonline commented Oct 26, 2024

Uh oh!

shubhamchasing commented Oct 27, 2024

Uh oh!

shubhamchasing commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandonroberts commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubhamchasing commented Oct 31, 2024

Uh oh!

nickytonline left a comment

Choose a reason for hiding this comment

Uh oh!

shubhamchasing commented Nov 4, 2024

Uh oh!

shubhamchasing commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shubhamchasing commented Oct 3, 2024 •

edited

Loading

netlify bot commented Oct 3, 2024 •

edited

Loading

netlify bot commented Oct 3, 2024 •

edited

Loading

shubhamchasing commented Oct 24, 2024 •

edited

Loading

shubhamchasing commented Oct 26, 2024 •

edited

Loading

shubhamchasing commented Oct 28, 2024 •

edited

Loading

brandonroberts commented Oct 30, 2024 •

edited

Loading