fix: Add missing pwa plugin #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for saucedocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jpmcb
reviewed
Jun 24, 2024
| @@ -3,7 +3,7 @@ | |||
| "version": "1.75.4", | |||
| "private": true, | |||
| "engines": { | |||
| "node": "^18.17.0 || >=20.5.0", | |||
| "node": "^18.17.0 || >=20.5.0", | |||
There was a problem hiding this comment.
Was there a missing commit? This doesn't look to have added anything, just a formatting / spacing change to the package.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build is still currently breaking. One of the problems is we don't have the pwa plugin installed. This PR installs the plugin and the build is working locally.
Related Tickets & Documents
closes #342
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?