-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instructions for Highlights Suggestions section #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
✅ Deploy Preview for saucedocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vivitt
changed the title
Add instructions for Highlights Suggestions section
docs: add instructions for Highlights Suggestions section
Jun 27, 2024
vivitt
changed the title
docs: add instructions for Highlights Suggestions section
feat: add instructions for Highlights Suggestions section
Jun 27, 2024
vivitt
force-pushed
the
highlight-suggestions
branch
from
June 27, 2024 08:47
5bf1021
to
2f20e38
Compare
BekahHW
reviewed
Jun 27, 2024
BekahHW
approved these changes
Jul 15, 2024
nickytonline
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @vivitt! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds instructions to use the Highlight Suggestions section when adding a highlight.
It adds two sub sections below the "How to Add a Highlight". One for adding a highlight with suggestions and the second for adding it manually.
It also updates the
highlight.gif
with a new one that shows that shows the suggestions.Related Tickets & Documents
Closes #224
Mobile & Desktop Screenshots/Recordings
This is how the Highlights docs looks after changes:
Steps to QA
highlight-suggestions
branchTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?