Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add livlaurel as a contributor #565

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

livlaurel
Copy link

@livlaurel livlaurel commented Nov 6, 2024

Description

This PR adds livlaurel as a contributor.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #565

Contributors Checklist

I've read through the Getting Started section

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

DD06956B-EC27-4597-AF1D-8A1DDDB4EF7E_4_5005_c

[optional] What GIF best describes this PR or how it makes you feel?

vibing

@livlaurel livlaurel requested a review from a team as a code owner November 6, 2024 19:35
Copy link

github-actions bot commented Nov 6, 2024

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @livlaurel! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@livlaurel livlaurel changed the title feat: Add livlaurel as a contributor feat: Add livlaurel as a contributor (#565) Nov 7, 2024
@adiati98
Copy link
Member

adiati98 commented Nov 8, 2024

Hi @livlaurel,
Thank you for your contribution! ✨

There's a slight change that you need to make in your PR template.
Can you remove the parentheses from your issue number? Having them would not close the issue automatically when the PR merge. It should be Closes #565.

Thank you. 🙂

@livlaurel livlaurel changed the title feat: Add livlaurel as a contributor (#565) feat: Add livlaurel as a contributor Nov 9, 2024
@livlaurel
Copy link
Author

Done! I just fixed the closes parentheses!

@adiati98
Copy link
Member

@BekahHW can I have the 2nd approval here? Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants