Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: npm package root path #19

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Aug 20, 2023

Description

This PR intends to make the pkgRoot value of the @semantic-release/npm plugin configurable which previously had a default value of ".".

This enables us to publish npm packages from sub-directories of a repo. For use in resolving open-sauced/pizza-cli#27.

A demo release using this configuration can be found here.
https://github.com/Anush008/xdg/releases/tag/v1.10.0

The config.
https://github.com/Anush008/xdg/blob/2bcf6c2d7121ed8f77a0c31679458052fbc8b74b/.github/workflows/release.yaml#L29-L35

The published sub-directory: https://www.npmjs.com/package/xdg-anush

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Related to open-sauced/pizza-cli#27.

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

@Anush008
Copy link
Member Author

cc @0-vortex.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Anush008 Anush008 requested review from bdougie and jpmcb August 20, 2023 16:45
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes you caught in git! 🚀 🍕

release.config.js Outdated Show resolved Hide resolved
@bdougie bdougie merged commit e62fc8a into open-sauced:main Aug 21, 2023
5 checks passed
@Anush008 Anush008 deleted the Anush008-patch-1 branch August 21, 2023 16:11
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants