Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestAgentIdentification/ws #216

Closed
wants to merge 2 commits into from

fix flaky TestAgentIdentification/ws second eventually assert

71b4d40
Select commit
Loading
Failed to load commit list.
Closed

Fix flaky TestAgentIdentification/ws #216

fix flaky TestAgentIdentification/ws second eventually assert
71b4d40
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Dec 1, 2023 in 0s

72.43% (-3.69%) compared to efddaa2

View this Pull Request on Codecov

72.43% (-3.69%) compared to efddaa2

Details

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (71b4d40) 72.43%.
Report is 31 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing ⚠️
client/internal/httpsender.go 88.00% 2 Missing and 1 partial ⚠️
client/internal/mockserver.go 85.71% 2 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
client/internal/clientcommon.go 90.90% 1 Missing ⚠️
client/internal/packagessyncer.go 0.00% 1 Missing ⚠️
server/serverimpl.go 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   76.11%   72.43%   -3.69%     
==========================================
  Files          24       25       +1     
  Lines        1834     2017     +183     
==========================================
+ Hits         1396     1461      +65     
- Misses        326      446     +120     
+ Partials      112      110       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov