Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evan-bradley as an approver #233

Conversation

tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan tigrannajaryan requested a review from a team January 9, 2024 21:26
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (1f6ede9) 72.50%.
Report is 39 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing ⚠️
client/internal/httpsender.go 88.00% 2 Missing and 1 partial ⚠️
client/internal/mockserver.go 85.71% 2 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
client/internal/clientcommon.go 90.90% 1 Missing ⚠️
client/internal/packagessyncer.go 0.00% 1 Missing ⚠️
client/internal/receivedprocessor.go 90.90% 1 Missing ⚠️
server/serverimpl.go 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   76.11%   72.50%   -3.62%     
==========================================
  Files          24       25       +1     
  Lines        1834     2022     +188     
==========================================
+ Hits         1396     1466      +70     
- Misses        326      446     +120     
+ Partials      112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm looking forward to helping out more.

@tigrannajaryan tigrannajaryan merged commit cc4739c into open-telemetry:main Jan 9, 2024
4 of 6 checks passed
@tigrannajaryan tigrannajaryan deleted the feature/tigran/evanapprover branch January 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants