Client reports download status and download details #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
commented
Jan 10, 2025
michel-laterman
changed the title
srikanthccv
reviewed
Jan 20, 2025
|
@michel-laterman are you still working on this? I left some comments above and the build is failing. |
|
@tigrannajaryan yes I'm working on it, but my time for this is very limited |
tigrannajaryan
approved these changes
Feb 24, 2025
When the client is downloading a package it will report the download status, and report download details (bytes per second and percent download) periodically.
Add feedback from review, not expected to pass until spec changes are made
michel-laterman
force-pushed
the
feat/package-download-details
branch
from
649c07d to
5b65daa
Compare
tigrannajaryan
requested changes
Feb 27, 2025
michel-laterman
force-pushed
the
feat/package-download-details
branch
from
773c6ed to
5b65daa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 80.10% 80.20% +0.09%
==========================================
Files 25 26 +1
Lines 2423 2495 +72
==========================================
+ Hits 1941 2001 +60
- Misses 374 383 +9
- Partials 108 111 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There's currently a race condition in a test I have yet to debug |
tigrannajaryan
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of downloading status along with download details details as described in open-telemetry/opamp-spec#206
When the client is downloading a package it will report the download status, and report download details (bytes per second and percent download) periodically.