Skip to content

Conversation

@tylerauerbeck
Copy link

As mentioned in #321 and associated issues/PR's, this PR adds golangci-lint configs (mostly adapted from the opentelemetry-collector config. This enables just the staticcheck linter for now since this is what it's replacing and then the standard formatters. The existing lints that needed fixed were then addressed in separate commits.

This also updates the appropriate workflow (now named lint.yaml) and runs it using the latest golangci-lint v2 version.

Resolves #321

Signed-off-by: Tyler Auerbeck <[email protected]>
Signed-off-by: Tyler Auerbeck <[email protected]>
Signed-off-by: Tyler Auerbeck <[email protected]>
Signed-off-by: Tyler Auerbeck <[email protected]>
@tylerauerbeck tylerauerbeck requested a review from a team as a code owner June 22, 2025 21:29
@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (27dba42) to head (3545caa).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
client/wsclient.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   80.20%   80.24%   +0.04%     
==========================================
  Files          26       26              
  Lines        2495     2495              
==========================================
+ Hits         2001     2002       +1     
  Misses        383      383              
+ Partials      111      110       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,27 @@
name: static-check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick): Should this be renamed to lint?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate lint stage checks with golangci-lint

2 participants