Wire up logs export #424
Merged
Wire up logs export #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
force-pushed
the
wire_up_logs_export
branch
from
63f2742 to
cf09f3e
Compare
Merged
marandaneto
approved these changes
Jun 11, 2024
LikeTheSalad
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will rebase after #421 is merged.
So far, logs export has been completely absent. In order for logs and events to make it out of the agent, we need logs to be wired up in some form. For now, just like spans, the basic default exporter just logs to the console (visible in logcat). This also adds a method that allows customization, which the demo app now uses to export to the emulator host.
I was able to use this to see events exported as logs in a locally running collector!
And just to be extra clear, this isn't really what #142 is asking for, because it doesn't bridge the android logger...it's just otel logs.