fix(network): modernize simplenetworkdetector with updated android apis

[orioonyx]

Related issue

This pull request resolves issue #735.

Summary of changes

This PR updates the SimpleNetworkDetector class to replace deprecated Android APIs with their modern counterparts while ensuring backward compatibility:

1. For API 29 and above:
   • Replaced getActiveNetworkInfo() with getActiveNetwork() and getNetworkCapabilities().
   • Used NetworkCapabilities.TRANSPORT_* constants to determine network type.
2. For API 28 and below:
   • Retained the existing logic using getActiveNetworkInfo() and TYPE_* constants to support older devices.

Additional improvements include:

• Added null checks to handle cases where modern APIs might return null.
• Simplified and aligned the code for better readability.

Why these changes are important

• Aligning with modern Android APIs ensures compatibility with Android 10 and newer versions.
• Maintaining backward compatibility supports older Android versions, benefiting a broader range of users.
• Improving code readability and structure enhances maintainability for future contributors.

Acknowledgment

Thank you for providing this opportunity to contribute to the project. I have done my best to follow the contribution guidelines and ensure the changes adhere to project standards.

If there are any further improvements or adjustments required, please let me know. I will be more than happy to address any feedback promptly.

Thank you for your time and consideration!

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: orioonyx / name: KyungEun (2474fff, 9fd2c4a, 24f194c, 6179531, 5a6156d)

[marandaneto]

Not possible to do activeNetwork.getSubtypeName() like the older APIs?

[orioonyx]

Thank you for the question!

Unfortunately, getSubtypeName() is not available in the newer APIs like NetworkCapabilities. The newer APIs focus on transport-level details (e.g., cellular, WiFi) rather than providing specific subtype information like "LTE" or "HSPA."

Thank you for your review and feedback! 😊

[marandaneto]

left a question otherwise LGTM

[breedx-splk]

The fact that this exists means that we will still get a build-time warning, right?

I think that if you factor out the body of the above if(api_29) block into a method, you could then also factor out the lower half of this method into a new method that we could suppress the warnings for. Just an idea.

[orioonyx]

Thank you so much for your valuable feedback and suggestions! 😊

I've addressed your comments by:

• Adding @RequiresApi(api = Build.VERSION_CODES.Q) to the detectUsingModernApi method to align with the API requirements for modern implementations.
• Improving code readability by refactoring the buildCurrentNetwork calls to adhere to the project's formatting standards.
• Running spotlessApply to ensure the code meets the required formatting rules.

Please let me know if there's anything else you'd like me to adjust or further refine. I'm more than happy to make additional changes based on your feedback.

Thank you again for taking the time to review my PR and for providing such helpful guidance!

[breedx-splk]

Thanks for the contribution. I think this is a step forward, but I made one suggestion about refactoring.

I think once this lands, we can convert it to kotlin and leverage pattern matching to make it even nicer. 👍🏻

[LikeTheSalad]

Thank you!