Factor out and make session timeouts more explicit. #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddas09
approved these changes
Mar 15, 2025
|
@breedx-splk, LGTM! However, I see similar changes also done in this PR. |
marandaneto
approved these changes
Mar 24, 2025
breedx-splk
force-pushed
the
session_config
branch
from
198d147 to
c732e6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #860. See the thread over there for additional details.
Basically, we have always intended to have two session "timeouts" -- one that is a maximum absolute lifespan (4 hour default) and a background inactivity timeout (15 minute default). Somewhere along the way, these two values were blended, and the same timeout value was ultimately used for both.
The purpose of this PR is to once again separate these two times, and to make their names and usages more explicit.