add convenience event emitting api to OpenTelemetryRum #892
Conversation
| * | ||
| * @param eventName The name of the event to emit. | ||
| */ | ||
| default void emitEvent(String eventName) { |
There was a problem hiding this comment.
What do you think about doing this in Kotlin and collapsing all these methods into one and use default arguments?
There was a problem hiding this comment.
it looks like that's very possible.
There was a problem hiding this comment.
FYI: it won't be very nice to Java users though.
There was a problem hiding this comment.
you can add the annotation @JvmOverloads so kotlin generates overloads for the java callers
There was a problem hiding this comment.
It looks like that would require making the function a class method instead of being declare in an interface?
There was a problem hiding this comment.
you can just do method overloads with kotlin anyway so its ok to convert it to kotlin
There was a problem hiding this comment.
oh true that, you can make this interface an abstract class but not sure if that's what you want
i was thinking the same. however, i don't know whether others would want it to changed to a class.
you can just do method overloads with kotlin anyway so its ok to convert it to kotlin
it looks like that defeats the purpose of converting to kotlin?
There was a problem hiding this comment.
it looks like that defeats the purpose of converting to kotlin?
i think we all want at some point that the codebase is kotlin only when it makes sense.
all new code ideally is kotlin, if its not a big pain.
your call here since it works already
There was a problem hiding this comment.
Maybe for now just keep this in Java and we can convert the whole class to Kotlin at a later point. There might be some binary compatibility issues in that case, but we can do it in a version bump where doing some trivial compile time breaks are ok.
Fixes #573