Add AssertionExtensions to work around upstream stability #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Migrate NetworkChangeMonitorTest to kotlin.
breedx-splk
force-pushed
the
event_name_extension
branch
from
bee9f12 to
abb183c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will rebase after #895 is merged (builds on #895).
Given this unfortunate situation with "stability" in the core assertions, let's come up with our own extension(s) for doing assertions. This starts with
hasEventName()on theLogRecordDataAssert.This PR also migrates the
NetworkChangeMonitorTestto kotlin and mockk in order to demonstrate usage of the extension assert.