Migrate network instrumentation to kotlin #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Mar 24, 2025
|
|
||
| fun LogRecordDataAssert.hasEventName(eventName: String): LogRecordDataAssert { | ||
| isNotNull() | ||
| // TODO: This will be removed after the event bits of logs gets out of incubating. |
There was a problem hiding this comment.
just a note I guess? or should we create an issue?
There was a problem hiding this comment.
I think the note is fine....once incubator changes it should force us to notice.
marandaneto
approved these changes
Mar 24, 2025
breedx-splk
force-pushed
the
network_inst_kotlin
branch
from
1c86481 to
c11cb05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will rebase after #900 is merged.
Based on this comment, we want to simplify the network instrumentation by migrating it to kotlin, which eliminates the explicit BiConsumer ugliness. In the process of doing this, it also became apparent that the
NetworkChangeMonitorclass wasn't really pulling its weight, so its only small method was just brought into theinstall()for the instrumentation....further simplifying things.