add build-time android.util.Log call-site substitutions
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...main/java/io/opentelemetry/instrumentation/library/log/internal/LogRecordBuilderCreator.java
Outdated
Show resolved
Hide resolved
...rary/src/main/java/io/opentelemetry/instrumentation/library/log/AndroidLogSubstitutions.java
Outdated
Show resolved
Hide resolved
...rary/src/main/java/io/opentelemetry/instrumentation/library/log/AndroidLogSubstitutions.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Mar 31, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/library/log/AndroidLogSubstitutions.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Mar 31, 2025
|
|
||
| public class AndroidLogSubstitutions { | ||
|
|
||
| public static String TAG_KEY = "android.tag"; |
There was a problem hiding this comment.
Actually, the guidance is more to use the AttributeKey class, because avoids having to make a new AttributeKey each time (like the pure string version does).
Suggested change
| public static String TAG_KEY = "android.tag"; | |
| public final static AttributeKey<String> TAG_KEY = AttributeKey.stringKey("android.tag"); |
|
Along with our goal of having READMEs for each instrumentation that describe the telemetry they omit, I think we should include a README in this PR. Thanks! |
breedx-splk
reviewed
Apr 2, 2025
breedx-splk
reviewed
Apr 2, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/library/log/AndroidLogSubstitutions.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
This is looking good, @cleverchuk thanks for the submission! I'd like us to reference the semconv before merging, and I think we should open an issue to convert some of the assertions to use the upstream test utils, which has more expressive type-specific assertsions for the logs classes....but I think we're close. 😎
breedx-splk
reviewed
Apr 4, 2025
breedx-splk
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe fixes #142