Skip to content

[statsdreceiver] add test for empty statsd tags #32336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2024
Merged

[statsdreceiver] add test for empty statsd tags #32336

merged 3 commits into from
Jul 22, 2024

Conversation

@diurnalist
Copy link
Contributor

@diurnalist diurnalist commented Apr 11, 2024 •
edited by codeboten
Loading

Description: we see some payloads with completely empty tags, which we can safely ignore. This is already handled by the receiver, but we did not have a test for it.

Close #32337

Testing: adds simple test to receiver

Documentation: n/a

@diurnalist diurnalist requested a review from a team April 11, 2024 23:51
@github-actions github-actions bot added the receiver/statsd statsd related issues label Apr 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Apr 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels May 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 31, 2024
@diurnalist diurnalist force-pushed the b/statsd-empty-tags branch from 9088c4f to 5defde4 Compare June 11, 2024 21:48
@diurnalist
Copy link
Contributor Author

diurnalist commented Jun 11, 2024

@jmacd @dmitryax I would appreciate a look at this one, I am trying to keep it up to date w/ the upstream changes. It does not look to me that the failed checks are related to the PR changes.

@github-actions github-actions bot removed the Stale label Jun 12, 2024
@diurnalist
Copy link
Contributor Author

diurnalist commented Jun 25, 2024

@atoulme is there any interest in this bugfix?

atoulme
atoulme approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple enough, and guarding against input seems like a good idea.

@atoulme
Copy link
Contributor

atoulme commented Jun 25, 2024

@diurnalist take a look at the conflict and see if your test passes with latest main without your modification.

@diurnalist
[statsdreceiver] add test for empty statsd tags
989265c 
we see some payloads with completely empty tags, which we can
safely ignore. there is already support for this in the receiver;
this simply adds a test to track future regressions on this behavior.
@diurnalist diurnalist force-pushed the b/statsd-empty-tags branch from 5defde4 to 989265c Compare June 25, 2024 23:35
@diurnalist
Copy link
Contributor Author

diurnalist commented Jun 25, 2024

@atoulme yeah I just noticed that a change 4 days ago obviated the need for this :p - i guess this PR's only contribution then is the test itself, I think the other PR fixed the panic issue as a side-effect :)

@diurnalist diurnalist changed the title [statsdreceiver] handle empty statsd tags [statsdreceiver] add test for empty statsd tags Jun 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 10, 2024
atoulme
atoulme approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests sound good thanks!

dmitryax
dmitryax reviewed Jul 10, 2024
View reviewed changes
.chloggen/b_statsd-empty-tags.yaml Outdated
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
Copy link
Member

@dmitryax dmitryax Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a changelog for test. Please remove this

@dmitryax dmitryax added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Stale labels Jul 10, 2024
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Jul 16, 2024
@codeboten codeboten merged commit 5ed0eb5 into open-telemetry:main Jul 22, 2024
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryax dmitryax dmitryax left review comments

@atoulme atoulme atoulme approved these changes

@codeboten codeboten codeboten approved these changes

@jmacd jmacd Awaiting requested review from jmacd

Assignees

@atoulme atoulme

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/statsd statsd related issues Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v0.106.0

Development

Successfully merging this pull request may close these issues.

[statsdreceiver] fail to parse payloads with empty tag data

4 participants

@diurnalist @atoulme @codeboten @dmitryax