[extension/storage/redis_storage] Add a new Redis extension to store data in transit #33224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
add_redis_storage_extension
branch
3 times, most recently
from
d9c2864 to
0c3284b
Compare
atoulme
force-pushed
the
add_redis_storage_extension
branch
from
0c3284b to
1c2e4aa
Compare
atoulme
force-pushed
the
add_redis_storage_extension
branch
2 times, most recently
from
663993f to
57a8302
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
Not stale, waiting for review. |
atoulme
force-pushed
the
add_redis_storage_extension
branch
from
57a8302 to
d19100b
Compare
atoulme
force-pushed
the
add_redis_storage_extension
branch
3 times, most recently
from
70712d9 to
62c87bb
Compare
evan-bradley
approved these changes
Jul 2, 2024
Contributor
evan-bradley
left a comment
evan-bradley
left a comment
There was a problem hiding this comment.
I have limited experience with storage extensions, but this looks good to me for a first pass. All of my suggestions are non-blocking.
Contributor
Author
|
@open-telemetry/collector-contrib-approvers please review |
atoulme
force-pushed
the
add_redis_storage_extension
branch
from
1a33f73 to
bbc8fc1
Compare
crobert-1
reviewed
Jul 10, 2024
crobert-1
approved these changes
Jul 12, 2024
Co-authored-by: Evan Bradley <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
atoulme
force-pushed
the
add_redis_storage_extension
branch
7 times, most recently
from
d10733a to
050f2bf
Compare
atoulme
force-pushed
the
add_redis_storage_extension
branch
from
050f2bf to
34b2b10
Compare
Contributor
|
@atoulme Anything left to do here, or are we good to merge? |
Contributor
Author
|
Ready to merge |
Contributor
|
@andrzej-stencel I merged this to keep things moving since it's a new component, but feel free to offer any follow-up feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new extension allowing to store data in transit in a Redis cluster.
Link to tracking Issue:
Fixes #31682
Testing:
Unit tests
Documentation:
README