-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[processor/resourcedetection] Add EKS cluster name subsection in README #34140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA
94663a6 to
421df2d
Compare
|
@songy23 Done |
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
421df2d to
73070de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding this example is indeed useful I think the motivation for it surfaces a more generic issue. That has to do with how intuitive and useful is the current format of the attributes' documentation. Users reading the main README.md have to head to the metadata.yaml files to look for more precise "documentation". Not all users might be familiar with this though.
Maybe having an autogenerated .md file listing all the attributes like how it's done in the receivers' docs would be useful?
@ChrsMark I agree, can you open an issue to add this mdatagen? |
Fixes #34139