[exporter/clickhouse] Use the standard default of 10 queue consumers #34176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
suggested changes
Jul 19, 2024
Member
SpencerTorres
left a comment
SpencerTorres
left a comment
There was a problem hiding this comment.
Good find, we just need to add a changelog entry. Appreciate the contribution!
Contributor
Author
|
Thanks @SpencerTorres, I added a changelog entry |
SpencerTorres
approved these changes
Jul 19, 2024
crobert-1
approved these changes
Jul 19, 2024
crobert-1
added
the
ready to merge
Contributor
|
Huh. I thought I had raised an issue about this a long time ago and it had previously been resolved. Odd. |
Contributor
|
Hmm .. Ok. Maybe I should have made top-level issue for it instead. Good that it's now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The default number of queue consumers is in the exporter helper 10. This default is respected by every other exporter in this repo except for the ClickHouse exporter. A default of 1 is way too low for any major workload and adds a low ceiling to the vertical scalability of a single collector.
Link to tracking Issue: n/a
Testing: n/a
Documentation: Added the default values to the README