Skip to content

Conversation

@songy23
Copy link
Member

@songy23 songy23 commented Jul 22, 2024

When feature gate connector.datadogconnector.NativeIngest is enabled:

  1. Spans with attribute _dd.measured: 1 should always get APM stats
  2. When the new enable_otlp_compute_top_level_by_span_kind feature is enabled, non-root spans with client or producer span kind should get stats

@songy23 songy23 requested a review from mx-psi as a code owner July 22, 2024 20:09
@songy23 songy23 requested a review from a team July 22, 2024 20:09
@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command connector/datadog exporter/datadog Datadog components labels Jul 22, 2024
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good expect one comment

@mx-psi mx-psi merged commit 0393a45 into open-telemetry:main Jul 29, 2024
@github-actions github-actions bot added this to the next release milestone Jul 29, 2024
@songy23 songy23 deleted the dd-deps branch July 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd/otelcontribcol otelcontribcol command connector/datadog exporter/datadog Datadog components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants