[chore][receiver/vcenter] Reworked Integration test for vCenter #34201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following PR works to make the integration tests a bit more deterministic by taking advantage of the govmomi simulator. Previously the integration test had the following line when comparing
Which is a bit of a hacky fix that addressed an issue where the simulator had inconsistent VM to Host assignments between test runs.
Although ignoring the resource attribute value currently works, it breaks once datacenter metrics are enabled by default
This PR hopes to make the integration tests more consistent and accurate going forward.
Link to tracking Issue:
Testing:
scraperinttest.WriteExpected()Documentation: