fix: property endpoint is ignored when using instrumentation_key #34399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
Hi @dashpole , @pcwiese and @bogdandrutu , is there anyone could help to review this PR? thx! |
Contributor
|
Looks like @pcwiese is the codeowner, and is the person you need to review before this can be merged |
Contributor
Author
|
Looks no response for about one month, could anyone else help on that or any suggestion? @dashpole @bogdandrutu |
pcwiese
approved these changes
Sep 4, 2024
dashpole
approved these changes
Sep 6, 2024
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
The fix is trivial, so i'm approving. It would be good to have unit tests to catch these sorts of problems in general, though
dashpole
added
the
ready to merge
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…n-telemetry#34399) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Fixing a bug **Link to tracking Issue:** open-telemetry#33971 **Testing:** It's just one line and simple, so I just tested locally. If test cases needed, I can provide in this PR. **Documentation:** if no connection string and endpoint is provided, then use it instead of the default one. --------- Co-authored-by: David Ashpole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug
Link to tracking Issue: #33971
Testing: It's just one line and simple, so I just tested locally. If test cases needed, I can provide in this PR.
Documentation: if no connection string and endpoint is provided, then use it instead of the default one.