[processor/tailsampling]: Enable inverse filtering for boolean attribute filter #34730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute filter Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jpkrohling
reviewed
Sep 6, 2024
Member
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
The change itself looks OK, but can you add a documentation to the readme? It would also be nice to have a concrete use case listed there.
Contributor
Author
sure, will add docs for this today |
Signed-off-by: Florian Bacher <[email protected]>
jpkrohling
approved these changes
Sep 18, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ute filter (open-telemetry#34730) **Description:** This PR adds the `invert_match` option for `boolean_attribute` filters, as discussed in open-telemetry#34296 (comment) **Link to tracking Issue:** open-telemetry#34296 **Testing:** Added unit tests **Documentation:** The existing documentation already covered the semantics of the `invert_match` option --------- Signed-off-by: Florian Bacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds the
invert_matchoption forboolean_attributefilters, as discussed in #34296 (comment)Link to tracking Issue: #34296
Testing: Added unit tests
Documentation: The existing documentation already covered the semantics of the
invert_matchoption