[connector/datadog] Update README for accuracy #35121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13 and
mx-psi
songy23
added
documentation
mx-psi
reviewed
Sep 10, 2024
mx-psi
approved these changes
Sep 11, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** The current description of the Datadog connector implies that it is only useful in the presence of sampling. However, its use is actually required to see trace-emitting services and their statistics in Datadog APM. This PR rewords the README to reflect that more clearly. I also fixed some indentation issues in the provided example. **Link to tracking Issue:** No tracking issue on Github. Internal Jira issue: OTEL-1776 --------- Co-authored-by: Pablo Baeyens <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current description of the Datadog connector implies that it is only useful in the presence of sampling. However, its use is actually required to see trace-emitting services and their statistics in Datadog APM. This PR rewords the README to reflect that more clearly.
I also fixed some indentation issues in the provided example.
Link to tracking Issue: No tracking issue on Github. Internal Jira issue: OTEL-1776