[chore] [receiver/couchdb] Use confighttp.NewDefaultClientConfig instead of manually creating struct #35613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of manually creating struct **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
29 tasks
crobert-1
reviewed
Oct 4, 2024
| @@ -26,14 +26,14 @@ func NewFactory() receiver.Factory { | |||
| } | |||
|
|
|||
| func createDefaultConfig() component.Config { | |||
| clientConfig := confighttp.NewDefaultClientConfig() | |||
| clientConfig.TLSSetting = configtls.ClientConfig{} | |||
There was a problem hiding this comment.
Suggested change
| clientConfig.TLSSetting = configtls.ClientConfig{} | |
| clientConfig.TLSSetting = configtls.NewDefaultClientConfig() |
Should we update this reference too it's the same underlying concern?
There was a problem hiding this comment.
These changes are for confighttp. I can create another issue for configtls similarely to #35457 ?
There was a problem hiding this comment.
Sure, another issue would probably be good. It looks like the goal is to move all configs over the the NewDefault... initialization, as noted here, but I understand it's unrelated to this PR so we don't have to do it yet. 👍
There was a problem hiding this comment.
crobert-1
approved these changes
Oct 4, 2024
dmitryax
approved these changes
Oct 5, 2024
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…ead of manually creating struct (open-telemetry#35613) **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes usage of
NewDefaultClientConfiginstead of manually creating the confighttp.ClientConfig struct.Link to tracking Issue: #35457