Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure Storage FlashArray - Purity v6.6.11+ Native OpenMetrics Support #36251

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

chrroberts-pure
Copy link
Contributor

@chrroberts-pure chrroberts-pure commented Nov 6, 2024

This PR implements the changes required to scrape metrics from arrays with newer Purity versions.

In Pure Storage FlashArray Purity version 6.6.11, they released a feature that allows OpenMetrics to be scraped directly from the array without the use of an OpenMetrics Exporter.

These changes include

  • Enabling support to disable TLS Insecure Skip Verify if required (default is to verify)
  • Enabling support for the namespace HTTP param that is supported by the Purity OpenMetrics exporter.

Link to tracking issue

None

Testing

Tests have been updated for the scraper and default configs for the new Namespace and TLSInsecureSkipVerify configurations.

I have tested this with a live FlashArray running 6.6.11

Documentation

The Readme was updated to show a new example of a scrape using Purity version 6.6.11+.

@atoulme
Copy link
Contributor

atoulme commented Nov 7, 2024

Please add tests.

@chrroberts-pure
Copy link
Contributor Author

@atoulme Tests have been added. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants