[pkg/ottl] Add ParseSeverity function
#37280
Open
+632
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
TylerHelmuth,
bogdandrutu,
edmocosta,
evan-bradley and
kentquirk
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
… made to mapGetter Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
commented
Jan 20, 2025
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Member
|
@bacherfl is this still draft? |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Florian Bacher <[email protected]>
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
@edmocosta I have now updated the PR to convert the mapping literal at the time of the function's initialisation, rather than parsing it at each invocation of the function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
ParseSeverityfunction, as discussed in the linked ticket. I also had to make a minor change to theinternal
mapGetter, handling the map literals to return a rawmap[string]any, instead of apcommon.Map. This is because if there is a map literal within a slice, thepcommon.Slice.FromRawcannot handle thepcommon.Map, as it only works with raw data types.This change is however transparent, and the behavior to the outside of this package does not change.
EDIT: After merging main with the support for value expressions, introduced in #36883, this would affect the type of values returned by
ParseValueExpression- previously this could potentially returnmap[string]any/[]any, but with the changes introduced in this PR, this would return apcommon.Map/pcommon.Slice.Please let me know if I should do this change in a separate PR though.
Link to tracking issue
Fixes #35079
Testing
Added unit and e2e tests
Documentation
Describe new function in the readme