Skip to content

Revert "[exporter/elasticsearch] use validation for batcher" #38254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Revert "[exporter/elasticsearch] use validation for batcher" #38254

merged 1 commit into from
Feb 27, 2025

Conversation

@songy23
Copy link
Member

@songy23 songy23 commented Feb 27, 2025

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 27, 2025
@songy23 songy23 requested a review from a team as a code owner February 27, 2025 20:08
@songy23 songy23 requested a review from jpkrohling February 27, 2025 20:08
@VihasMakwana
Copy link
Contributor

VihasMakwana commented Feb 27, 2025 •
edited
Loading

I can push a fix for this, but should we revert and reopen #38072 with fix or I can push a fix directly? wdyt @songy23

i think we should probably revert it just to be on safer side. I'll reopen the PR with the fix.

@songy23
Copy link
Member Author

songy23 commented Feb 27, 2025

@VihasMakwana I took a look as well, you will need to replace the deprecated BatcherConfig in elastic exporter's Config and it is a breaking change: min_size_items -> min_size etc.
So would prefer to revert first

@songy23 songy23 merged commit 765ed69 into main Feb 27, 2025
162 of 165 checks passed
@songy23 songy23 deleted the revert-38072-fix-batcher-elasticsearchexporter branch February 27, 2025 20:25
@github-actions github-actions bot added this to the next release milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@carsonip carsonip Awaiting requested review from carsonip

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@lahsivjar lahsivjar Awaiting requested review from lahsivjar

Assignees

@fatsheep9146 fatsheep9146

Labels

exporter/elasticsearch Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v0.121.0

Development

Successfully merging this pull request may close these issues.

4 participants

@songy23 @VihasMakwana @TylerHelmuth @fatsheep9146