-
Notifications
You must be signed in to change notification settings - Fork 3.1k
pkg/translator/pprof: initial commit #43975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
…4003-6f29b34c24f6 Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
|
@florianl do you have an issue for creating a package? |
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
I think I managed to resolve them. |
|
If it has no public API, how do we have the receiver draw on it? Will this be addressed in a separate PR? |
@atoulme This is just the first step to move the code. There will be a public API and we should put some thoughts on it. |
Co-authored-by: Antoine Toulme <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
VihasMakwana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just a question about changelog
understood. |
Description
Move code from
receiver/pprofreceiverto new componentpkg/translator/pprof.This helps to provide easier and unified access to transformation functionality between pprof and OTel profiles. It also helps to have the transformation functionality for pprof to OTel profiles and vice versa in one place and therefore should simplify testing.
At this stage no public API is exposed for the component
pkg/translator/pprof.Link to tracking issue
Fixes
Testing
Documentation