Skip to content

Conversation

@florianl
Copy link
Contributor

@florianl florianl commented Nov 3, 2025

Description

Move code from receiver/pprofreceiver to new component pkg/translator/pprof.
This helps to provide easier and unified access to transformation functionality between pprof and OTel profiles. It also helps to have the transformation functionality for pprof to OTel profiles and vice versa in one place and therefore should simplify testing.

At this stage no public API is exposed for the component pkg/translator/pprof.

Link to tracking issue

Fixes

Testing

Documentation

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
…4003-6f29b34c24f6

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@MovieStoreGuy
Copy link
Contributor

@florianl do you have an issue for creating a package?

@florianl
Copy link
Contributor Author

florianl commented Nov 4, 2025

do you have an issue for creating a package?

I think I managed to resolve them.

@atoulme
Copy link
Contributor

atoulme commented Nov 5, 2025

If it has no public API, how do we have the receiver draw on it? Will this be addressed in a separate PR?

@florianl
Copy link
Contributor Author

florianl commented Nov 6, 2025

If it has no public API, how do we have the receiver draw on it? Will this be addressed in a separate PR?

@atoulme This is just the first step to move the code. There will be a public API and we should put some thoughts on it.
As moving code shows, this code is not used at all in pprofreceiver at the moment, so there is no break in functionality.

Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just a question about changelog

@atoulme
Copy link
Contributor

atoulme commented Nov 7, 2025

If it has no public API, how do we have the receiver draw on it? Will this be addressed in a separate PR?

@atoulme This is just the first step to move the code. There will be a public API and we should put some thoughts on it. As moving code shows, this code is not used at all in pprofreceiver at the moment, so there is no break in functionality.

understood. Maybe you could copy the code over for now if you want time to think on the API, so we can wire the code in the receiver meanwhile. that's the case, so we're ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants