Skip to content

Conversation

@odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 6, 2025

Link to tracking issue

Part of #43891

@odubajDT odubajDT marked this pull request as ready for review November 6, 2025 11:52
@odubajDT odubajDT requested a review from a team as a code owner November 6, 2025 11:53
@odubajDT odubajDT requested a review from axw November 6, 2025 11:53
@github-actions github-actions bot requested a review from rlankfo November 6, 2025 11:53
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Does this impact Kubernetes version compatibility at all?

I feel it would be worth adding a changelog entry even if it's not meant to have any user impact, so users can find the change in the release notes in case of any unexpected behaviour.

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 7, 2025

Code looks good. Does this impact Kubernetes version compatibility at all?

I feel it would be worth adding a changelog entry even if it's not meant to have any user impact, so users can find the change in the release notes in case of any unexpected behaviour.

If I am correct, this should shift the k8s version to 1.21 (instead of 1.17), so realistically, this should not affect users using the latest collector builds.

I am not completely sure about the changelog, if yes, it should cover all components linked in the issue and not only the loadbalancing exporter

@axw
Copy link
Contributor

axw commented Nov 7, 2025

If I am correct, this should shift the k8s version to 1.21 (instead of 1.17), so realistically, this should not affect users using the latest collector builds.

Thanks, that was my read of the docs too. I think we should still call this out as a breaking change, despite Kubernetes 1.20 being ~5 years old. Doesn't hurt does it?

I am not completely sure about the changelog, if yes, it should cover all components linked in the issue and not only the loadbalancing exporter

This PR is only changing the loadbalancing exporter though. We can add an entry for each component change?

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 7, 2025

If I am correct, this should shift the k8s version to 1.21 (instead of 1.17), so realistically, this should not affect users using the latest collector builds.

Thanks, that was my read of the docs too. I think we should still call this out as a breaking change, despite Kubernetes 1.20 being ~5 years old. Doesn't hurt does it?

I am not completely sure about the changelog, if yes, it should cover all components linked in the issue and not only the loadbalancing exporter

This PR is only changing the loadbalancing exporter though. We can add an entry for each component change?

I agree it would not hurt, but effectively it should realistically not affect any user. If you would agree, I would add a changelog entry for all components in this PR, since some of the PRs were already merged.

@axw
Copy link
Contributor

axw commented Nov 7, 2025

I agree it would not hurt, but effectively it should realistically not affect any user. If you would agree, I would add a changelog entry for all components in this PR, since some of the PRs were already merged.

Ah ok, didn't see the others. SGTM.

@odubajDT odubajDT force-pushed the loadbalancingexporter-deprecated-k8s branch from 034d3db to 7fda262 Compare November 7, 2025 08:59
@songy23 songy23 merged commit 8599eb6 into open-telemetry:main Nov 7, 2025
189 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants