-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[receiver/googlepubsubpush] Add skeleton #44085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
songy23
merged 11 commits into
open-telemetry:main
from
constanca-m:add-googlepubsubpushreceiver-skeleton
Nov 7, 2025
Merged
[receiver/googlepubsubpush] Add skeleton #44085
songy23
merged 11 commits into
open-telemetry:main
from
constanca-m:add-googlepubsubpushreceiver-skeleton
Nov 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
reviewed
Nov 6, 2025
Contributor
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few things.
Co-authored-by: Andrew Wilkins <[email protected]>
axw
approved these changes
Nov 7, 2025
Contributor
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the bit about latency is dropped from the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accepted Component
New component has been sponsored
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add skeleton to the google pub sub push receiver.
Link to tracking issue
Fixes #43503.
Testing
Testing added for the configuration.
Documentation
README provided.