[receiver/prometheusremotewritereceiver] accept unspecified histograms #44091
+197
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly-afk
requested review from
a team,
ArthurSens and
dashpole
as code owners
perebaj
reviewed
Nov 6, 2025
| switch ts.Metadata.Type { | ||
| case writev2.Metadata_METRIC_TYPE_HISTOGRAM: | ||
| histMetric.Metadata().PutStr(prometheus.MetricMetadataTypeKey, "histogram") | ||
| default: |
Contributor
There was a problem hiding this comment.
isn't not missing this case -> writev2.Metadata_METRIC_TYPE_UNSPECIFIED
jelly-afk
force-pushed
the
support-unspecified-histogram
branch
from
c6d7120 to
27a2adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prometheusremote write receiver now accepts histogram with unspecified metric type.
Link to tracking issue
Fixes #41840
Testing
Added two test cases in the TestTranslateV2 test function to test unspecified histograms.