[receiver/googlecloudpubsubpush] Add implementation #44101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
commented
Nov 7, 2025
| "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/googlecloudpubsubpushreceiver/internal/metadata" | ||
| ) | ||
|
|
||
| var receivers = sharedcomponent.NewSharedComponents() |
Contributor
Author
There was a problem hiding this comment.
I have added them to a shared receivers map @axw
constanca-m
commented
Nov 7, 2025
Comment on lines
+107
to
+124
| if p.nextLogs != nil { | ||
| start = true | ||
| logsUnmarshaler, errLoad := loadEncodingExtension[encoding.LogsUnmarshalerExtension]( | ||
| host, p.cfg.Encoding, "logs", | ||
| ) | ||
| if errLoad != nil { | ||
| return fmt.Errorf("failed to load encoding extension: %w", errLoad) | ||
| } | ||
| addHandlerFunc( | ||
| mux, | ||
| logsEndpoint, | ||
| logsUnmarshaler.UnmarshalLogs, | ||
| p.nextLogs.ConsumeLogs, | ||
| p.storageClient, | ||
| p.cfg.IncludeMetadata, | ||
| p.settings.Logger, | ||
| ) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The logic changed a bit to what we have internally. This is so we can adapt to other signals easily. Logs will now be sent to a logs endpoint, /logs instead of / @axw Is that ok? I know for AWS firehose receiver we wanted to remove this, but this seems necesssary 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add implementation to the googlecloudpubsubpush receiver.
Testing
Unit tests added.
Documentation
README already up to date.