Fix issue #43183 opensearch exporter dynamic log index feature puts logs in wrong index #44112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpensearchExporter-Dynamic-log-index-feature-puts-logs-in-wrong-index-
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opensearch exporter is resolving the indexname of an entire block of multiple resourceLogs at one time.
It overlooks the fact that dynamic indexNames might/will vary at each resourceLog.
This MR fixes this by resolving the dynamic indexName at each new resourceLog.
Link to tracking issue
Fixes #43183
Testing
Tests for resolving indexName with multiple resourceLogs.
(Also other duplicate test have been removed)
Documentation
None