[chore][pprofiles] Fix pprofile DurationNano to be a TypeUint64 #44397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complementary change to open-telemetry/opentelemetry-collector#14188. Signed-off-by: Florian Lehner <[email protected]>
florianl
requested review from
a team,
TylerHelmuth,
VihasMakwana,
edmocosta,
evan-bradley and
fatsheep9146
as code owners
github-actions
bot
requested review from
atingchen,
dao-jun,
douglascamata,
iblancasa and
povilasv
douglascamata
suggested changes
Nov 19, 2025
| binary.LittleEndian.PutUint64(id[:8], uint64(i)) | ||
| profile.SetProfileID(id) | ||
| profile.SetDuration(pcommon.NewTimestampFromTime(time.Now().Add(time.Second))) | ||
| profile.SetDurationNano(1000000000) |
Member
There was a problem hiding this comment.
Suggested change
| profile.SetDurationNano(1000000000) | |
| profile.SetDurationNano((1 * time.Second).Nanoseconds()) |
This looks much more readable.
The same also applies to all the other similar occurrences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complementary change to open-telemetry/opentelemetry-collector#14188.
Link to tracking issue
Fixes
Testing
Documentation