[receiver/fluentforward] Ensure all established connections are properly closed on shutdown #45145
+125
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
tokuhirom
force-pushed
the
feature/fluentforward-connection-close-on-shutdown-44433
branch
from
d50d660 to
829517a
Compare
…rly closed on shutdown Fixes shutdown behavior so that all existing connections are closed cleanly. Adds tests to verify proper connection closure. Fixes open-telemetry#44433
tokuhirom
force-pushed
the
feature/fluentforward-connection-close-on-shutdown-44433
branch
from
829517a to
de2d83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes shutdown behavior so that all existing connections are closed cleanly. Adds tests to verify proper connection closure.
Description
#44433
Link to tracking issue
Fixes #44433
Testing
Add the test case to check the connection closed.
Documentation