-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Make service discoveries removable through Go build tags #45148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArthurSens
wants to merge
3
commits into
open-telemetry:main
Choose a base branch
from
ArthurSens:removable-sds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm opening this PR just to show how it works, but discussions should be done upstream at prometheus/prometheus :) |
Contributor
|
Moving to draft since this is not to be merged. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
af03e66 to
ee41b09
Compare
Member
Author
|
PR finally ready for review @dashpole :) I've also updated the PR description to mention how to test these changes |
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
01c72ac to
c40d814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/googlemanagedprometheus
Google Managed Prometheus exporter
exporter/prometheus
exporter/prometheusremotewrite
internal/datadog/e2e
pkg/translator/loki
pkg/translator/prometheusremotewrite
receiver/loki
receiver/prometheus
Prometheus receiver
receiver/prometheusremotewrite
receiver/purefa
receiver/purefb
receiver/simpleprometheus
Stale
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is built on top of prometheus/prometheus#17736. There are a lot of go mod changes, and that also inherits fixes to interface changes that were made since Prometheus 3.8
The only change that is really about making SDs removable is this change in imports in
factory.go:Link to tracking issue
Fixes #44406
Testing
Used two builder configs and measured the binary size difference:
Without build tags(120MB):
With build tags(63MG):