Skip to content

Commit

Permalink
feedback from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jackgopack4 committed Feb 14, 2025
1 parent f22d762 commit 5e6ee04
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
7 changes: 5 additions & 2 deletions service/hostcapabilities/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ module go.opentelemetry.io/collector/service/hostcapabilities

go 1.23.0

require go.opentelemetry.io/collector/service v0.119.0
require (
go.opentelemetry.io/collector/component v0.119.0
go.opentelemetry.io/collector/pipeline v0.119.0
go.opentelemetry.io/collector/service v0.119.0
)

require (
github.com/gogo/protobuf v1.3.2 // indirect
go.opentelemetry.io/collector/component v0.119.0 // indirect
go.opentelemetry.io/collector/pdata v1.25.0 // indirect
go.opentelemetry.io/otel v1.34.0 // indirect
go.opentelemetry.io/otel/metric v1.34.0 // indirect
Expand Down
6 changes: 6 additions & 0 deletions service/hostcapabilities/interfaces.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
package hostcapabilities // import "go.opentelemetry.io/collector/service/hostcapabilities"

import (
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/pipeline"
"go.opentelemetry.io/collector/service/internal/moduleinfo"
)

Expand All @@ -15,4 +17,8 @@ type ModuleInfo interface {
// GetModuleInfos returns the module information for the host
// i.e. Receivers, Processors, Exporters, Extensions, and Connectors
GetModuleInfos() moduleinfo.ModuleInfos

// TODO: remove as part of https://github.com/open-telemetry/opentelemetry-collector/issues/7370 for service 1.0
// Deprecated: [v0.120.0] Will be removed in Service 1.0.
GetExporters() map[pipeline.Signal]map[component.ID]component.Component
}
12 changes: 0 additions & 12 deletions service/internal/graph/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,8 @@ import (
"go.opentelemetry.io/collector/service/internal/zpages"
)

// TODO: remove as part of https://github.com/open-telemetry/opentelemetry-collector/issues/7370 for service 1.0
type getExporters interface {
GetExporters() map[pipeline.Signal]map[component.ID]component.Component
}

type getModuleInfos interface {
// GetModuleInfo returns the module information for the host.
GetModuleInfos() moduleinfo.ModuleInfos
}

var (
_ getExporters = (*Host)(nil)
_ component.Host = (*Host)(nil)
_ getModuleInfos = (*Host)(nil)
_ hostcapabilities.ModuleInfo = (*Host)(nil)
)

Expand Down

0 comments on commit 5e6ee04

Please sign in to comment.