Skip to content

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 21, 2024

Description

Use string value for stringy types

Link to tracking issue

Fixes #10937

Testing

Adds tests for stringy type recognition and adds end to end tests

@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (b10029c) to head (c9684e1).
Report is 1 commits behind head on main.

Files Patch % Lines
confmap/confmap.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10938      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files         411      411              
  Lines       19311    19327      +16     
==========================================
+ Hits        17745    17759      +14     
- Misses       1217     1218       +1     
- Partials      349      350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi force-pushed the mx-psi/map-types-support branch from d79c469 to 2861abc Compare August 21, 2024 15:06
@mx-psi mx-psi force-pushed the mx-psi/map-types-support branch from 2861abc to 097f58b Compare August 21, 2024 15:29
@mx-psi mx-psi marked this pull request as ready for review August 21, 2024 16:11
@mx-psi mx-psi requested review from a team and atoulme August 21, 2024 16:11
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mx-psi. Just on question

@mx-psi mx-psi merged commit 17b39d1 into open-telemetry:main Aug 26, 2024
@mx-psi mx-psi deleted the mx-psi/map-types-support branch August 26, 2024 11:22
@github-actions github-actions bot added this to the next release milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing expansion of map string values that look like another type

4 participants