-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[consumer] Mark module as stable #11492
base: main
Are you sure you want to change the base?
Conversation
cc @open-telemetry/collector-approvers |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11492 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 433 433
Lines 23617 23617
=======================================
Hits 21607 21607
Misses 1642 1642
Partials 368 368 ☔ View full report in Codecov by Sentry. |
I would merge this after the release to not rush it. Are we ok with that? |
Definitely, and regardless of the release let's at least wait for a few days at least in case somebody has an objection |
It seems that the current API only permits passing signal-agnostic |
Fromt he 2024-10-28 Collector stability meeting, @bogdandrutu will take a look and see if we should do #11492 (comment) |
Description
Mark
consumer
module as stable. This is now possible after #11491, sinceconsumererror
is a separate module now.Link to tracking issue
Fixes #9046