[exporterqueue] Limited worker pool support for queue batcher #11540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11540 +/- ##
=======================================
Coverage 91.45% 91.46%
=======================================
Files 438 438
Lines 23827 23842 +15
=======================================
+ Hits 21791 21806 +15
Misses 1658 1658
Partials 378 378 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-queue-tiny-2
branch
from
a5d504c
to
e67d36c
Compare
|
@sfc-gh-sili please rebase |
sfc-gh-sili
force-pushed
the
sili-queue-tiny-2
branch
from
e67d36c
to
bfdafe9
Compare
|
Just FIY, adding |
dmitryax
pushed a commit
that referenced
this pull request
Oct 30, 2024
…d exports (#11546) #### Description This PR follows #11540 and implements support for item-count based batching for queue batcher. Limitation: This PR supports merging request but not splitting request. In other words, it support specifying a minimum request size but not a maximum request size. Design doc: https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing #### Link to tracking issue #8122 #10368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows #11532 and implements support for limited worker pool for queue batcher.
Design doc:
https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing
Link to tracking issue
#8122
#10368
Documentation